Skip to content

🧑‍🌾 Fix cpplint regression#186

Closed
Crola1702 wants to merge 1 commit intorollingfrom
Crola1702/fix-cpplint
Closed

🧑‍🌾 Fix cpplint regression#186
Crola1702 wants to merge 1 commit intorollingfrom
Crola1702/fix-cpplint

Conversation

@Crola1702
Copy link

Fixes projectroot.cpplint regression:

/home/jenkins-agent/workspace/nightly_linux_debug/ws/src/ros2/rmw_connextdds/rmw_connextdds_common/src/common/rmw_type_support.cpp:16:  Found C system header after C++ system header. Should be: rmw_type_support.h, c system, c++ system, other.  [build/include_order] [4]

Reference build: https://ci.ros2.org/view/nightly/job/nightly_linux_debug/3396/

Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
@Crola1702 Crola1702 self-assigned this Apr 17, 2025
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Crola1702 #184 already addresses it.

@Crola1702
Copy link
Author

@Crola1702 #184 already addresses it.

Ahh my bad for not looking at fixes before. Thanks for the ping

@Crola1702 Crola1702 closed this Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants