Merged
Conversation
Signed-off-by: Andrea Sorbini <asorbini@rti.com>
asorbini
added
bug
Collaborator
Author
|
Full CI:
|
ivanpauno
approved these changes
Apr 14, 2021
asorbini
added a commit
that referenced
this pull request
Apr 14, 2021
asorbini
added a commit
that referenced
this pull request
Apr 14, 2021
asorbini
added a commit
that referenced
this pull request
Apr 14, 2021
This was referenced Apr 14, 2021
asorbini
added a commit
that referenced
this pull request
Apr 14, 2021
asorbini
added a commit
that referenced
this pull request
Apr 14, 2021
asorbini
added a commit
that referenced
this pull request
Apr 14, 2021
hidmic
approved these changes
Apr 15, 2021
Collaborator
Author
|
@hidmic @ivanpauno thank you for the reviews! Is it ok if I merge the PR myself or should I let someone else do it? |
delete-merged-branch
bot
deleted the
asorbini/fix-empty-message-detection
branch
Member
If it's approved (two approvals during the galactic freeze) and there was no comment saying it should be merged after the galactic freeze finishes, you can merge it yourself. (edit) with CI passing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in
RMW_Connext_MessageTypeSupport::type_info()which prevents correct detection of empty messages when querying thefastrtpstype support.No test is currently failing because of this (AFAIK), but it seems a critical fix to properly support empty messages.
This bug was spotted by @MiguelCompany and it is already fixed in #14, but since that PR might be delayed to H-turtle, we should probably commit the fix separately.