Add stub dynamic network interface implementation.#99
Add stub dynamic network interface implementation.#99jakymiws wants to merge 2 commits intoros2:rollingfrom
Conversation
Signed-off-by: Sebastian Jakymiw <sjakymiw@irobot.com>
| * This function returns `NULL` when either the node handle is `NULL` or when the | ||
| * node handle is from a different rmw implementation. | ||
| * | ||
| * \return rmw_ret_t non `NULL` value if successful, otherwise `NULL` |
There was a problem hiding this comment.
this comment seems wrong (the function does not return NULL and it does not take a node handle as argument)
There was a problem hiding this comment.
Ah whoops. That is left over from the actual implementation. I will fix.
Signed-off-by: Sebastian Jakymiw <sjakymiw@irobot.com>
asorbini
left a comment
asorbini
left a comment
There was a problem hiding this comment.
Looks good to me, thank you for the contribution @jakymiws.
The PR can be merged once ros2/rclcpp#2086 and other related PRs are moved forward and approved.
I guess it wouldn't hurt merging it sooner than that either, since it only adds new functions, but I would prefer to wait for the feature to be approved.
| } | ||
|
|
||
| rmw_ret_t | ||
| rmw_notify_participant_dynamic_network_interface(rmw_context_t * context) |
There was a problem hiding this comment.
Minor comment, which applies more to the rmw interface that this specific change, but I always prefer to pass const pointers, e.g.:
| rmw_notify_participant_dynamic_network_interface(rmw_context_t * context) | |
| rmw_notify_participant_dynamic_network_interface(rmw_context_t * const context) |
3 participants
Per this ros2/rclcpp#2086 (comment) comment on a related PR, this PR seeks to add a stubbed version of a feature developed for rmw_fastrtps: ros2/rmw_fastrtps#662 so that if this feature is called with an rmw layer that does not implement the feature, it returns an error that can be handled.
Signed-off-by: Sebastian Jakymiw sjakymiw@irobot.com