Revert ServicePubListener API break#475
Merged
hidmic merged 2 commits intoros2:masterfrom Dec 1, 2020
Merged
Conversation
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
clalancette
approved these changes
Oct 28, 2020
Contributor
clalancette
left a comment
clalancette
left a comment
There was a problem hiding this comment.
Seems reasonable to me, I'll run CI on it next.
Contributor
|
CI:
|
jacobperron
approved these changes
Oct 28, 2020
Member
jacobperron
left a comment
jacobperron
left a comment
There was a problem hiding this comment.
Thanks @JLBuenoLopez-eProsima !
jacobperron
requested changes
Oct 28, 2020
rmw_fastrtps_shared_cpp/include/rmw_fastrtps_shared_cpp/custom_service_info.hpp
Show resolved
Hide resolved
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
clalancette
approved these changes
Oct 29, 2020
Contributor
clalancette
left a comment
clalancette
left a comment
There was a problem hiding this comment.
Looks good with green CI.
jacobperron
approved these changes
Oct 29, 2020
Contributor
|
@JLBuenoLopez-eProsima check MacOS CI failures! |
Contributor
Author
Contributor
|
Nope ! Re-running CI:
|
hidmic
approved these changes
Dec 1, 2020
Contributor
hidmic
left a comment
hidmic
left a comment
There was a problem hiding this comment.
Test failures seem unrelated, LGTM !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#467 introduced an API break that it is not required for the workaround. This pull request reverts that break.
Signed-off-by: JLBuenoLopez-eProsima joseluisbueno@eprosima.com