[foxy] Redo "Discriminate when the Client has gone from when the Client has not completely matched"#490
Merged
jacobperron merged 2 commits intofoxyfrom Dec 8, 2020
Merged
Conversation
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Member
Author
|
CI with Fast-RTPS dynamic:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert #489 (9094971) and add a patch to fix the reported bug (34a23d5).
I think the issue was that the shared function for sending the service response assumes we are using the patched version of the service listener, and I had not updated the
rmw_fastrtps_dynamic_cppimplementation to use this type. This PR fixes that issue.