Allow null arguments in the EventsExecutor parameters#602
Merged
Conversation
…ion" This reverts commit 8e93400. Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
j-rivero
force-pushed
the
jrivero/fix_check_null
branch
from
4728b35 to
5fbe71d
Compare
clalancette
approved these changes
May 5, 2022
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
fujitatomoya
changed the title
Contributor
Author
|
While reviewing the error logs in the past builds I noticed that probably the problem was only in checking callbacks that can be So I think that we can leave the checks on the other parameters:
|
clalancette
approved these changes
May 5, 2022
Contributor
clalancette
left a comment
clalancette
left a comment
There was a problem hiding this comment.
Still looks OK, assuming CI comes back green.
Contributor
|
This PR and #600 should be backported to Humble to address the build regressions on the |
Blast545
pushed a commit
that referenced
this pull request
May 11, 2022
* Revert "Add RMW_CHECKS to EventsExecutor implementation" * Check the non callback values for nullptr Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
timonegk
pushed a commit
to timonegk/rmw_fastrtps
that referenced
this pull request
May 21, 2022
* Revert "Add RMW_CHECKS to EventsExecutor implementation" * Check the non callback values for nullptr Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
timonegk
pushed a commit
to timonegk/rmw_fastrtps
that referenced
this pull request
Jun 8, 2022
* Revert "Add RMW_CHECKS to EventsExecutor implementation" * Check the non callback values for nullptr Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After merging #600, failing tests have appeared in rclcpp that points to problems with assertions introduced on parameter there.
I did that following the API that explicit mention when a parameter can be null (i.e.
user_data). Seems to me like the null check and error handling is being done at a different place of the stack.Testing: