Add EventsExecutor API for dynamic_fastrtps (Humble)#604
Closed
Add EventsExecutor API for dynamic_fastrtps (Humble)#604
Conversation
Mostly a copy of the implementation done for rmw_fastrtps_cpp. Fixes #599. Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
To keep the both rmw_fastrtps_ implementations in sync with respect to argument checking. Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
* Revert "Add RMW_CHECKS to EventsExecutor implementation" * Check the non callback values for nullptr Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Contributor
Author
|
Closing in favor of #605 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of the last three commits in master adding EventsExecutor api to the rmw dynamic_fastrtps.
I'm not sure if this as a backport should be squash merged or just leave the three commits that are in master as well.
I left #601 outside of the backport, should this one be backported?