Merged
Conversation
ahcorde
reviewed
Apr 5, 2024
rmw_fastrtps_shared_cpp/include/rmw_fastrtps_shared_cpp/utils.hpp
Outdated
Show resolved
Hide resolved
Mario-DL
force-pushed
the
feature/rolling/keys
branch
from
9b3b8a9 to
32b2145
Compare
fujitatomoya
reviewed
Nov 5, 2024
Collaborator
fujitatomoya
left a comment
fujitatomoya
left a comment
There was a problem hiding this comment.
a couple of minor comments. i tried review and i think this looks good, but this needs to be reviewed by someone from eProsima or other maintainers who know this area...
rmw_fastrtps_shared_cpp/include/rmw_fastrtps_shared_cpp/utils.hpp
Outdated
Show resolved
Hide resolved
Collaborator
Author
MiguelCompany
force-pushed
the
feature/rolling/keys
branch
from
017f34c to
60aa7de
Compare
Collaborator
Author
|
CI with this repos file:
|
fujitatomoya
approved these changes
Apr 5, 2025
Collaborator
fujitatomoya
left a comment
fujitatomoya
left a comment
There was a problem hiding this comment.
@MiguelCompany i am not sure how much my review matters here, but i reviewed the whole thing, and had a few comments.
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
…ption Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
…keys adoption Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
MiguelCompany
force-pushed
the
feature/rolling/keys
branch
from
60aa7de to
06b640d
Compare
Collaborator
Author
|
@fujitatomoya I rebased this and addressed your review. Thank you! |
Collaborator
Author
|
New CI with this repos file:
|
ahcorde
approved these changes
Apr 7, 2025
Contributor
ahcorde
left a comment
ahcorde
left a comment
There was a problem hiding this comment.
There are some missing includes, probably there are more, I don't want to delay this merge of this PR, we can include them in a follow up PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the necessary code to support topic instances in
rmw_fastrtps_cppandrmw_fastrtps_dynamic_cpp@keyannotation rosidl#796@keyannotation rosidl_typesupport_fastrtps#116