Add test to check rmw_send_response when the client is gone#162
Merged
hidmic merged 1 commit intoros2:masterfrom Dec 1, 2020
Merged
Add test to check rmw_send_response when the client is gone#162hidmic merged 1 commit intoros2:masterfrom
hidmic merged 1 commit intoros2:masterfrom
Conversation
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
hidmic
approved these changes
Oct 22, 2020
Contributor
hidmic
left a comment
hidmic
left a comment
There was a problem hiding this comment.
LGTM, thanks @JLBuenoLopez-eProsima !
Contributor
|
CI up to
|
Contributor
|
@ros-pull-request-builder retest this please |
Contributor
|
@ros-pull-request-builder retest this please |
Contributor
|
Argh, docker hub limits... @ros-pull-request-builder retest this please |
Contributor
|
Alright, CI is happy and so am I. Thanks @JLBuenoLopez-eProsima ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test checks that
rmw_send_responsesendsRMW_RET_OKwhen the client has gone before sending the response.I have checked that this test fails with the current
rmw_fastrtps_cppandrmw_fastrtps_dynamics_cppimplementations but it passes with changes from ros2/rmw_fastrtps#467.Other rmw implementations tested under this package are currently passing the test.
Signed-off-by: JLBuenoLopez-eProsima joseluisbueno@eprosima.com