Draft
Conversation
added 2 commits
November 17, 2020 21:21
* Adds cmake file that parses package include resp. exclude list * Filtering cmake dependencies based on include/exclude list ros2#284 Signed-off-by: norro <github@norro.de>
* CMake passes package include/ignore lists to python scripts generating the bridge c++ code * Generation of factories and mappings restricted to packages filtered by include/ignore lists ros2#284 Signed-off-by: norro <github@norro.de>
Author
|
@clalancette I would very much appreciate your feedback. |
Contributor
|
Is the goal a feature that ignores ROS packages at compile time? If so, I would recommend a user interface of a CMake variable specified on the command line. When using |
Author
|
@sloretz Yes, that's right. Thanks for your feedback! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces package whitelist resp. blacklist, see #284.
If a file
${CMAKE_SOURCE_DIR}/../../../BridgePackageInclude.List"is found and non-empty (one ROS package name per line), only those ROS packages are mapped by the bridge.Otherwise, if a file
${CMAKE_SOURCE_DIR}/../../../BridgePackageIgnore.List"is found and non-empty (one ROS package name per line), those ROS packages are ignored by the bridge.This PR is very much work-in-progress with feedback appreciated, especially regarding the following points:
I consider message blacklist/whitelist as a next (and additional) step, after implementing this package blacklist/whitelist.