Allow .msg/.srv files to be in subdirectories of msg/, srv/#325
Open
janstrohbeck wants to merge 1 commit intoros2:masterfrom
Open
Allow .msg/.srv files to be in subdirectories of msg/, srv/#325janstrohbeck wants to merge 1 commit intoros2:masterfrom
janstrohbeck wants to merge 1 commit intoros2:masterfrom
Conversation
Signed-off-by: Jan Strohbeck <jan.strohbeck@uni-ulm.de>
janstrohbeck
force-pushed
the
allow_message_subdirectories
branch
from
fbe169a to
7c72fc7
Compare
Member
|
@janstrohbeck You wouldn't happen to have a test of a minimal reproducible example I can use to verify this works, would you? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If one has the following ROS1 message layout:
That is, the
.msgfiles are not directly in themsgfolder, but in subfolders. Then the bridge does not find the message files correctly. The same goes for files in subfolders in thesrvdirectory. This PR expands the search for.msgand.srvfiles to subdirectories, to make it work.