change order in node initialization#339
Open
sgermanserrano wants to merge 1 commit intoros2:masterfrom
Open
Conversation
Signed-off-by: Servando German Serrano <servando.german.serrano@gmail.com>
Collaborator
fujitatomoya
left a comment
fujitatomoya
left a comment
There was a problem hiding this comment.
a couple of comments.
- Is this modification only required to
parameter_bridge? probably we need to apply this fix to other places such assimple_bridge? - it would be nice to add test to make sure.
| rclcpp::init(argc, argv); | ||
| auto ros2_node = rclcpp::Node::make_shared("ros_bridge"); | ||
|
|
||
| // ROS 1 node |
Collaborator
There was a problem hiding this comment.
perhaps we would want to add comments why this rclcpp::init needs to be called before ros::init.
Collaborator
|
CC: @iuhilnehc-ynos |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows comment in #316
Signed-off-by: Servando German Serrano servando.german.serrano@gmail.com