Added support for custom parameter bridge node names#402
Open
ayushghosh21 wants to merge 1 commit intoros2:masterfrom
Open
Added support for custom parameter bridge node names#402ayushghosh21 wants to merge 1 commit intoros2:masterfrom
ayushghosh21 wants to merge 1 commit intoros2:masterfrom
Conversation
ayushghosh21
requested review from
gbiggs,
methylDragon and
quarkytale
as code owners
Signed-off-by: Ayush Ghosh <ayushghosh21@gmail.com>
|
Heey @ayushghosh21, maybe it can help you, I opened the PR #396 some time ago and with the changes I did there you can change any ROS arg for the ROS 1 and the ROS 2 nodes, including the name, namespace and so on. |
ipa-rwu
added a commit
to ipa-rwu/ros1_bridge
that referenced
this pull request
Mar 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In cases where you may need to run multiple parameter bridges at the same time (eg: in multiple docker containers connected to the same ROS1 master) I was unable to run due to bridge nodes containing the same name. Initially passing in a command to rename the ros2 bridge is not successful because ROS1 and ROS2 parse the command line arguments differently.
Here, I am simply accounting for that, by reformatting the command line argument passed into ROS1 bridge node. This way I am able to specify custom names for the parameter bridge and therefore run multiple instances of the parameter bridge.
You can now simply pass in the arguments for a custom node name for the parameter bridge: