Open
Conversation
Signed-off-by: Olivier Kermorgant <olivier_kermorgant@yahoo.fr>
…Y and IGNORE options at compile time Signed-off-by: Olivier Kermorgant <olivier_kermorgant@yahoo.fr>
oKermorgant
requested review from
gbiggs,
methylDragon and
quarkytale
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reduces the number of compiled packages and messages, in order to only consider the ones that make sense.
As discussed in #410 this leads to far less code generation and reduces the compilation time.
Besides, two options
ROS1_BRIDGE_ONLYandROS1_BRIDGE_IGNOREallow listing ROS 2 packages that should be compiled, or ignored. Dependencies are handled automatically and by designIGNOREhas priority overONLY.This was tested on 22.04 / Humble (from binary) and ROS 1 Debian packages. As far as I know there is no reason to support ROS 1 from source, but nothing has changed on this part in the Python script anyway.