Open
Conversation
outrider-jhulas
requested review from
gbiggs,
methylDragon and
quarkytale
as code owners
Signed-off-by: outrider-jhulas <jhulas@outrider.ai>
outrider-jhulas
force-pushed
the
add-ros1-latching-pubs
branch
from
a69d66b to
8b955d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently a topic on ros2 side with
transient_localQoS will be published as a non-latching topic on the ros1 side, which can lead to undesired behavior.This PR proposes to use the
durabilityqos of the ros2 subscriber and create a latching ros1 publisher if thedurabilityistransient_local