Skip to content

[Feature/Dynamic_bridge] Add --fix-ros2-names CLI arg#443

Open
ghost wants to merge 1 commit intoros2:masterfrom
ColinChargyYona:fix_ros2_names
Open

[Feature/Dynamic_bridge] Add --fix-ros2-names CLI arg#443
ghost wants to merge 1 commit intoros2:masterfrom
ColinChargyYona:fix_ros2_names

Conversation

@ghost
Copy link

@ghost ghost commented Feb 4, 2025

This PR adds --fix-ros2-names CLI arg to automatically modify topic name which starts with a number (because it's invalid for ROS2 topic). ROS1 would allow names like "/lidar/bottom/1_2v" but ROS2 wouldn't:

terminate called after throwing an instance of 'rclcpp::exceptions::InvalidTopicNameError'
  what():  Invalid topic name: topic name token must not start with a number:
  '/lidar/bottom/1_2v'

This PR adds an underscore so the modified topic name would be valid in ROS2 ("" in the example)

…y modify topic name which starts with a number (because it's invalid for ROS2 topic)
@ghost ghost requested review from gbiggs, methylDragon and quarkytale as code owners February 4, 2025 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant