[Feature/Dynamic_bridge] Add --fix-ros2-names CLI arg#443
Open
ghost wants to merge 1 commit intoros2:masterfrom
Open
[Feature/Dynamic_bridge] Add --fix-ros2-names CLI arg#443ghost wants to merge 1 commit intoros2:masterfrom
ghost wants to merge 1 commit intoros2:masterfrom
Conversation
…y modify topic name which starts with a number (because it's invalid for ROS2 topic)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds --fix-ros2-names CLI arg to automatically modify topic name which starts with a number (because it's invalid for ROS2 topic). ROS1 would allow names like "/lidar/bottom/1_2v" but ROS2 wouldn't:
This PR adds an underscore so the modified topic name would be valid in ROS2 ("" in the example)