bugfix: Use SFINAE to add overloads that handle std::vector/std::array of bool#446
Open
mendes-jose wants to merge 2 commits intoros2:masterfrom
Open
bugfix: Use SFINAE to add overloads that handle std::vector/std::array of bool#446mendes-jose wants to merge 2 commits intoros2:masterfrom
mendes-jose wants to merge 2 commits intoros2:masterfrom
Conversation
mendes-jose
requested review from
gbiggs,
methylDragon and
quarkytale
as code owners
Signed-off-by: José Mendes <mendesfilho@protonmail.com>
mendes-jose
changed the title
… ambiguity Signed-off-by: José Mendes <mendesfilho@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to solve the compilation error we get when messages have at least one field of type
bool[].This has been discussed in other places, like in these issues here: #445, #393, #391
Also, there has been a PR which proposes a different solution to the same problem: #411
However, I think the solution adopted in this PR here (#446) is superior:
enable_if_t)Tests
The following video shows the bi-directional bridge of messages using vectors of bools based on my version of
ros1_bridge:fix-bool-vec.mp4