Add ROS-O support and fix compatibility issues#462
Open
iory wants to merge 3 commits intoros2:masterfrom
Open
Conversation
clalancette
requested changes
Oct 29, 2025
Contributor
There was a problem hiding this comment.
So this file is adding in completely new functionality to the bridge, and also taking a dependency on ros_control::controller_manager_msgs without declaring it in the package.xml. I'm going to say that we should not take this part of the change. The rest of it is fine with me.
Author
There was a problem hiding this comment.
Thanks. I've removed the commits related to controller_manager_msgs.
Also, before this can be merged, we need to enable the ros-o repositories in our GitHub Actions, which is handled in ros-tooling/setup-ros#854 and ros-tooling/action-ros-ci#1008 .
Could you please take a look at that PR as well?"
- Add support for ROS 1 One (ROS-O) distribution - Configure matrix builds for multiple ROS distros combinations - Add manual workflow trigger option - Update actions to versions with ROS-O support Signed-off-by: Iori Yanokura <ab.ioryz@gmail.com>
Skip pep257 linting test to resolve compatibility issues with Python 3.8 and ament_pep257 0.11.4 Signed-off-by: Iori Yanokura <ab.ioryz@gmail.com>
Implement specialized serialization functions for std::vector<bool> to handle proxy object references correctly in ROS message conversion. Adds read, write, and length stream operations. Signed-off-by: Iori Yanokura <ab.ioryz@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for testing ros1_bridge with ROS-O (ROS One) and fixes compatibility issues when testing with the noetic + rolling combination.
Changes
Copyright header
controller_manager_msgs_controller_state_adapter.cpppep257 compatibility fix
ament_pep257 0.11.4) has a compatibility issue with Python 3.8ValueError: too many values to unpack (expected 3)CI workflow updates
Build fixes
Related PRs
This PR is part of a series to add ROS-O support to the ROS tooling ecosystem:
setup-ros: Add ROS-O repository and installation support
action-ros-ci: Add ROS-O distribution recognition
ros1_bridge (this PR): Enable testing with ROS-O and fix compatibility issues
Together, these PRs enable:
Testing
With these changes, the CI successfully tests:
All tests pass successfully with these combinations.
Technical details
The pep257 skip is necessary because:
ament_pep257 0.11.4Breaking changes
None. These are additive changes that:
Signed-off-by: Iori Yanokura ab.ioryz@gmail.com