add ROS 2 ContentFilteredTopic for Humble Release Note.#2396
Merged
fujitatomoya merged 4 commits intoros2:rollingfrom May 2, 2022
Merged
add ROS 2 ContentFilteredTopic for Humble Release Note.#2396fujitatomoya merged 4 commits intoros2:rollingfrom
fujitatomoya merged 4 commits intoros2:rollingfrom
Conversation
Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
Collaborator
Author
fujitatomoya
commented
Apr 12, 2022
Collaborator
Author
fujitatomoya
left a comment
fujitatomoya
left a comment
There was a problem hiding this comment.
since this is release note, i tried to keep it simple.
here is a couple of questions, comments are really welcome.
- we should add description about currently only available with
rclcpp, butrclpy? - we should add an explanation about
rclcpp::ContentFilterOptions?
15 tasks
clalancette
reviewed
Apr 12, 2022
Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
fujitatomoya
added
the
backport-humble
Collaborator
Author
|
@clalancette @wjwwood could you take a look at this release note? i add the link for content filtering example. (we need to backport this to humble, labeled so.) |
wjwwood
reviewed
Apr 28, 2022
Member
wjwwood
left a comment
wjwwood
left a comment
There was a problem hiding this comment.
I have a few suggested edits, but lgtm otherwise.
Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
fujitatomoya
commented
Apr 28, 2022
Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
Collaborator
Author
|
I think it is ready to go! @clalancette @wjwwood requesting final review. |
clalancette
approved these changes
Apr 28, 2022
mergify bot
pushed a commit
that referenced
this pull request
May 2, 2022
* add ROS 2 ContentFilteredTopic for Humble Release Note. Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com> (cherry picked from commit 29c915b)
mergify bot
pushed a commit
that referenced
this pull request
May 2, 2022
* add ROS 2 ContentFilteredTopic for Humble Release Note. Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com> (cherry picked from commit 29c915b)
mergify bot
pushed a commit
that referenced
this pull request
May 2, 2022
* add ROS 2 ContentFilteredTopic for Humble Release Note. Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com> (cherry picked from commit 29c915b)
clalancette
pushed a commit
that referenced
this pull request
May 2, 2022
clalancette
pushed a commit
that referenced
this pull request
May 2, 2022
clalancette
pushed a commit
that referenced
this pull request
May 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tomoya.Fujita Tomoya.Fujita@sony.com