add tutorial for content filtering subscription.#2441
add tutorial for content filtering subscription.#2441fujitatomoya merged 5 commits intoros2:rollingfrom
Conversation
Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
fujitatomoya
added
enhancement
Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
fujitatomoya
force-pushed
the
20220427-content-filtering-tutorial
branch
from
d062dcd to
990b08d
Compare
clalancette
left a comment
clalancette
left a comment
There was a problem hiding this comment.
I've left a bunch of small changes inline. I think we'll be good to go once that is in (though I'd also like to get @wjwwood to review before we merge it).
|
@clalancette appreciate for many suggested fixes, i addressed them as suggested. |
Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com> Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
|
I've done a few more grammar changes in abee316 . At this point, this looks good to me, so I'm going to approve. @fujitatomoya I'd appreciate one more look from you just to make sure my latest changes are good with you. |
ivanpauno
left a comment
ivanpauno
left a comment
There was a problem hiding this comment.
Great work!
I have a lot of minor wording suggestions.
It would also be nice to not copy paste the code blocks, is it possible to link to the actual code instead?
Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com> Co-authored-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
i thought that would be nice too, but not sure how we can make it. i do not see any examples in current ros2_documents either. |
wjwwood
left a comment
wjwwood
left a comment
There was a problem hiding this comment.
Lgtm
We've always wanted to have a way to reference the content in the git repo, but we never implemented it.
* add tutorial for content filtering subscription. Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com> Co-authored-by: Chris Lalancette <clalancette@openrobotics.org> Co-authored-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com> (cherry picked from commit 7408ded)
* add tutorial for content filtering subscription. Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com> Co-authored-by: Chris Lalancette <clalancette@openrobotics.org> Co-authored-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com> (cherry picked from commit 7408ded)
* add tutorial for content filtering subscription. Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com> Co-authored-by: Chris Lalancette <clalancette@openrobotics.org> Co-authored-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com> (cherry picked from commit 7408ded) Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
4 participants
aligned with ros2/demos#557
Signed-off-by: Tomoya.Fujita Tomoya.Fujita@sony.com