Skip to content

Update Static Type Checking Changelog for Kilted rclpy #5368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
christophebedard merged 3 commits into from
Apr 25, 2025
Merged

Update Static Type Checking Changelog for Kilted rclpy #5368

christophebedard merged 3 commits into from
Apr 25, 2025

Conversation

@InvincibleRMC
Copy link
Contributor

@InvincibleRMC InvincibleRMC commented Apr 25, 2025

Based out of #5346

@InvincibleRMC
write rclpy typing changelog
0ef7d08 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC
Fix comma
94603ad 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
christophebedard
christophebedard reviewed Apr 25, 2025
View reviewed changes
Copy link
Member

@christophebedard christophebedard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@InvincibleRMC
Adress comments
03ed93e 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
christophebedard
christophebedard approved these changes Apr 25, 2025
View reviewed changes
Copy link
Member

@christophebedard christophebedard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@christophebedard
Copy link
Member

christophebedard commented Apr 25, 2025

Thanks for the PR!

Thanks for the PR!

Doesn't hurt to say it twice I guess 😆

@christophebedard christophebedard added the backport-all backport at reviewers discretion; from rolling to all versions label Apr 25, 2025
@christophebedard christophebedard merged commit 24d245c into ros2:rolling Apr 25, 2025
5 checks passed
mergify bot pushed a commit that referenced this pull request Apr 25, 2025
@InvincibleRMC @mergify
Update Static Type Checking Changelog for Kilted rclpy (#5368)
0309c77 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
(cherry picked from commit 24d245c)

# Conflicts:
#	source/Releases/Release-Kilted-Kaiju.rst
mergify bot pushed a commit that referenced this pull request Apr 25, 2025
@InvincibleRMC @mergify
Update Static Type Checking Changelog for Kilted rclpy (#5368)
043f4e1 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
(cherry picked from commit 24d245c)

# Conflicts:
#	source/Releases/Release-Kilted-Kaiju.rst
This was referenced Apr 25, 2025
Closed
Merged
@christophebedard
Copy link
Member

christophebedard commented Apr 25, 2025

@Mergifyio backport jazzy humble

@mergify
Copy link
Contributor

mergify bot commented Apr 25, 2025

backport jazzy humble

✅ Backports have been created

Details

christophebedard pushed a commit that referenced this pull request Apr 25, 2025
@InvincibleRMC @christophebedard
Update Static Type Checking Changelog for Kilted rclpy (#5368)
9ac4e1e 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
(cherry picked from commit 24d245c)
christophebedard pushed a commit that referenced this pull request Apr 25, 2025
@InvincibleRMC @christophebedard
Update Static Type Checking Changelog for Kilted rclpy (#5368)
d59cb43 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
(cherry picked from commit 24d245c)
christophebedard added a commit that referenced this pull request Apr 25, 2025
@christophebedard @InvincibleRMC
Update Static Type Checking Changelog for Kilted rclpy (#5368) (#5371)
d7f1ead 
(cherry picked from commit 24d245c)

Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Co-authored-by: Michael Carlstrom <rmc@carlstrom.com>
christophebedard pushed a commit that referenced this pull request Apr 25, 2025
@mergify @InvincibleRMC
Update Static Type Checking Changelog for Kilted rclpy (#5368) (#5370)
b4cebff 
(cherry picked from commit 24d245c)

Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Co-authored-by: Michael Carlstrom <rmc@carlstrom.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christophebedard christophebedard christophebedard approved these changes

Assignees

No one assigned

Labels

backport-all backport at reviewers discretion; from rolling to all versions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@InvincibleRMC @christophebedard