-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Enhanced explanation on ROS 2 main function #5985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: jazzy
Are you sure you want to change the base?
Conversation
Expanded explanation of the main function and ROS 2 initialization process. Signed-off-by: Arashdeep Singh <147547278+ArashdeepSinghMaan@users.noreply.github.com>
source/Tutorials/Beginner-Client-Libraries/Writing-A-Simple-Cpp-Publisher-And-Subscriber.rst
Outdated
Show resolved
Hide resolved
…p-Publisher-And-Subscriber.rst Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Signed-off-by: Arashdeep Singh <147547278+ArashdeepSinghMaan@users.noreply.github.com>
fujitatomoya
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
github workflow is not happy, can you check the followings?
https://github.com/ros2/ros2_documentation/actions/runs/19070568079/job/54471988670?pr=5985
https://github.com/ros2/ros2_documentation/actions/runs/19070568079/job/54471988719?pr=5985
source/Tutorials/Beginner-Client-Libraries/Writing-A-Simple-Cpp-Publisher-And-Subscriber.rst
Outdated
Show resolved
Hide resolved
ahcorde
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please @ArashdeepSinghMaan address the feedback related with CI
kscottz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix white space issues to pass linter.
source/Tutorials/Beginner-Client-Libraries/Writing-A-Simple-Cpp-Publisher-And-Subscriber.rst
Outdated
Show resolved
Hide resolved
source/Tutorials/Beginner-Client-Libraries/Writing-A-Simple-Cpp-Publisher-And-Subscriber.rst
Outdated
Show resolved
Hide resolved
source/Tutorials/Beginner-Client-Libraries/Writing-A-Simple-Cpp-Publisher-And-Subscriber.rst
Outdated
Show resolved
Hide resolved
source/Tutorials/Beginner-Client-Libraries/Writing-A-Simple-Cpp-Publisher-And-Subscriber.rst
Outdated
Show resolved
Hide resolved
source/Tutorials/Beginner-Client-Libraries/Writing-A-Simple-Cpp-Publisher-And-Subscriber.rst
Outdated
Show resolved
Hide resolved
source/Tutorials/Beginner-Client-Libraries/Writing-A-Simple-Cpp-Publisher-And-Subscriber.rst
Outdated
Show resolved
Hide resolved
…p-Publisher-And-Subscriber.rst Signed-off-by: Katherine Scott <katherineAScott@gmail.com>
…p-Publisher-And-Subscriber.rst Signed-off-by: Katherine Scott <katherineAScott@gmail.com>
…p-Publisher-And-Subscriber.rst Signed-off-by: Katherine Scott <katherineAScott@gmail.com>
…p-Publisher-And-Subscriber.rst Signed-off-by: Katherine Scott <katherineAScott@gmail.com>
…p-Publisher-And-Subscriber.rst Signed-off-by: Katherine Scott <katherineAScott@gmail.com>
source/Tutorials/Beginner-Client-Libraries/Writing-A-Simple-Cpp-Publisher-And-Subscriber.rst
Outdated
Show resolved
Hide resolved
…p-Publisher-And-Subscriber.rst Signed-off-by: Katherine Scott <katherineAScott@gmail.com>
|
@ahcorde i will leave this to you. |
Expanded explanation of the main function and ROS 2 initialization process.
Description
Fixes # (issue)
Did you use Generative AI?
Additional Information