-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New windows binary install instructions #6070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
knmcguire
wants to merge
11
commits into
ros2:rolling
Choose a base branch
from
knmcguire:new-win-bin-install
base: rolling
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
035d8f2
revert install location rolling
knmcguire 561a371
do everything in cmd prompt now
knmcguire c5b1b92
remove powershell from dev instructions too
knmcguire 79715d5
add installation script
knmcguire 7f5173a
change pixi_ws/ros2-windows to /dev/distro
knmcguire c9a7005
consistency command prompt
knmcguire d9fde87
command prompt consistency
knmcguire 0dc0593
fix typo
knmcguire a64a706
fix whitespace and codeblock issues ci
knmcguire c754417
Merge branch 'rolling' into new-win-bin-install
knmcguire 5689462
Merge branch 'rolling' into new-win-bin-install
mjcarroll File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not important for getting this in, but should we consider making this a `pixi task: https://pixi.sh/latest/workspace/advanced_tasks/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes absolutely, but that would require a PR to https://github.com/ros2/ros2, and this one is based on a PR in https://github.com/ros2/ci that just got merged after a half a year.
Also an alternative, is to also present an self-extracting archive with some automated post-extract command lines... still experimenting with that but that would be pretty close to an actual install and would further reduce the instructions. But that is still ongoing and perhaps would be to discuss this in an separate ticket perhaps.