Fix tests with new service and param present#838
Merged
clalancette merged 1 commit intoros2:rollingfrom Jul 7, 2023
Merged
Conversation
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
emersonknapp
force-pushed
the
emersonknapp/new-param-testfix
branch
from
3e9a51a to
5db1aa6
Compare
This was referenced Jul 6, 2023
Contributor
Author
|
Pulls: ros2/rclpy#1139, #838
|
clalancette
approved these changes
Jul 7, 2023
emersonknapp
added a commit
to emersonknapp/ros2cli
that referenced
this pull request
Jul 7, 2023
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
clalancette
pushed a commit
that referenced
this pull request
Jul 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of ros2/ros2#1159
Depends on ros2/rclpy#1139
ros2/rclpy#1139 starts a new service and introduces a new parameter to enable it. This PR fixes test expectations given the new situation, including turning off the new service on the daemon node.