Draft
Conversation
This commit correctly maps Bounded string/wstring IDL types to `rosidl_runtime_cpp::bounded_basic_string` types, rather than `std::basic_string` types. Signed-off-by: Abrar Rahman Protyasha <aprotyas@u.rochester.edu>
aprotyas
force-pushed
the
aprotyas/bounded_string_support
branch
from
d383778 to
8cab193
Compare
Contributor
|
@aprotyas any progress or plan on this? |
Member
Author
|
@fujitatomoya it'll be a while before I can get back to this (school gets in the way!), but I have a WIP BoundedString implementation that I'd integrate into this PR. Feel free to take over this PR though. Let me know if you do. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR consists of two parts:
bounded_basic_stringclass.bounded_basic_stringtypes, rather thanstd::basic_stringtypes.Fixes #637.
Signed-off-by: Abrar Rahman Protyasha aprotyas@u.rochester.edu