Add @optional support to rosidl_generator_cpp#882
Draft
InvincibleRMC wants to merge 25 commits intoros2:rollingfrom
Draft
Add @optional support to rosidl_generator_cpp#882InvincibleRMC wants to merge 25 commits intoros2:rollingfrom
rosidl_generator_cpp#882InvincibleRMC wants to merge 25 commits intoros2:rollingfrom
Conversation
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Contributor
Author
|
I believe this is as far this PR can go without updating each of the dds |
Contributor
Author
|
Found a bug in container type_traits working on a fix. |
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Co-authored-by: William Woodall <wjwwood@gmail.com> Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Signed-off-by: Chris Lalancette <clalancette@gmail.com> Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Co-authored-by: William Woodall <wjwwood@gmail.com> Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In Draft state since there are downstream
rmwproblems (tested with fastrps). I assume similar problems will occur with other rmw implementations.For example calling .size() on the
const class std::optional<std::__cxx11::basic_string<char> >A similar problem occurs with containers.
Fixes #850
Is this user-facing behavior change?
Since this adds optionals users will not have any breaking changes.
Did you use Generative AI?
Additional Information