Fix: only call imagedestroy() on PHP < 8#358
Open
AH72KING wants to merge 1 commit intorosell-dk:masterfrom
Open
Fix: only call imagedestroy() on PHP < 8#358AH72KING wants to merge 1 commit intorosell-dk:masterfrom
AH72KING wants to merge 1 commit intorosell-dk:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a check so that imagedestroy() is only called on PHP versions below 8, preventing unnecessary calls on newer PHP versions where it has no effect.
Private function added which will wrap & avoids deprecation warnings while keeping backward compatibility.
imagedestroy() has no effect since PHP 8.0 and is deprecated in PHP 8.5.