Add href to attributes to be searched#609
Open
nisbet-hubbard wants to merge 1 commit intorosell-dk:masterfrom
Open
Add href to attributes to be searched#609nisbet-hubbard wants to merge 1 commit intorosell-dk:masterfrom
href to attributes to be searched#609nisbet-hubbard wants to merge 1 commit intorosell-dk:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
<link>and<a>tags are searched by default:webp-express/vendor/rosell-dk/dom-util-for-webp/src/ImageUrlReplacer.php
Lines 41 to 44 in 18447e4
But their
hrefattributes aren’t searched, with the result that URLs in<link>and<a>don’t actually get replaced even when the relevant images have been converted.This PR fixed the issue.