Add raw response from ffprobe in MediaAnalysis#591
Open
mynameisbogdan wants to merge 1 commit intorosenbjerg:mainfrom
Open
Add raw response from ffprobe in MediaAnalysis#591mynameisbogdan wants to merge 1 commit intorosenbjerg:mainfrom
mynameisbogdan wants to merge 1 commit intorosenbjerg:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #591 +/- ##
==========================================
+ Coverage 71.20% 71.75% +0.55%
==========================================
Files 117 123 +6
Lines 2973 3548 +575
Branches 284 311 +27
==========================================
+ Hits 2117 2546 +429
- Misses 751 888 +137
- Partials 105 114 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
de3102e to
2b66841
Compare
Author
|
Might be cleaner at exposing the raw response, but you still need a method to parse the raw output (and not the process output) to fit your needs. Personally I need the raw response from analysis but others like GetFrames return the model used in deserialization unlike Analyse that returns a model different from the the deserialized model. |
2b66841 to
243cc64
Compare
243cc64 to
ac441ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposing the raw response from ffprobe in FFProbeAnalysis and MediaAnalysis, which would allow to be saved if needed as is without needing to remove
JsonIgnorefromFFProbeAnalysissince no serialization would be involved.