Skip to content

Add raw response from ffprobe in MediaAnalysis#591

Open
mynameisbogdan wants to merge 1 commit intorosenbjerg:mainfrom
mynameisbogdan:ffprobe-analysis-output-data
Open

Add raw response from ffprobe in MediaAnalysis#591
mynameisbogdan wants to merge 1 commit intorosenbjerg:mainfrom
mynameisbogdan:ffprobe-analysis-output-data

Conversation

@mynameisbogdan
Copy link

Exposing the raw response from ffprobe in FFProbeAnalysis and MediaAnalysis, which would allow to be saved if needed as is without needing to remove JsonIgnore from FFProbeAnalysis since no serialization would be involved.

@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.75%. Comparing base (1c4333e) to head (ac441ee).
⚠️ Report is 195 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #591      +/-   ##
==========================================
+ Coverage   71.20%   71.75%   +0.55%     
==========================================
  Files         117      123       +6     
  Lines        2973     3548     +575     
  Branches      284      311      +27     
==========================================
+ Hits         2117     2546     +429     
- Misses        751      888     +137     
- Partials      105      114       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mynameisbogdan mynameisbogdan force-pushed the ffprobe-analysis-output-data branch 3 times, most recently from de3102e to 2b66841 Compare October 18, 2025 16:09
@tqk2811
Copy link

tqk2811 commented Oct 20, 2025

Oh, better than #590
But i still need change internal to public in class MediaAnalysis ( #589 )

@mynameisbogdan
Copy link
Author

Might be cleaner at exposing the raw response, but you still need a method to parse the raw output (and not the process output) to fit your needs.

Personally I need the raw response from analysis but others like GetFrames return the model used in deserialization unlike Analyse that returns a model different from the the deserialized model.

@mynameisbogdan mynameisbogdan force-pushed the ffprobe-analysis-output-data branch from 2b66841 to 243cc64 Compare November 11, 2025 20:38
@mynameisbogdan mynameisbogdan force-pushed the ffprobe-analysis-output-data branch from 243cc64 to ac441ee Compare November 11, 2025 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants