Merged
Conversation
Fix GetCreationTime
Improve cancellation handling
…iontoken-is-used Ensure TestContext.CancellationToken is used
Improve test for percentage progress events
…e-sequence Fix fps handling in JoinImageSequence
… SubVideoAsync methods. Fixes #592.
Add metadata builder class
Throw OperationCancelledException in this case to provide more uniform and expected behavior. Fixes #594
…tion when FFProbe exits with non-zero code and no cancellation was requested. Ref.: #594
…andling cancellation. This preserves the original semantics and contract (throw only if the ffprobe exits with a non-zero code).
… call it separately in all the async code paths.
…eption_On_Cancellation Do not throw unexpected FFMpegException on FFProbe cancallation. Fixes #594
…lation-token Improve tests usage of cancellation token
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## release #598 +/- ##
===========================================
+ Coverage 68.67% 69.55% +0.87%
===========================================
Files 122 123 +1
Lines 3467 3544 +77
Branches 305 311 +6
===========================================
+ Hits 2381 2465 +84
+ Misses 972 964 -8
- Partials 114 115 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…pport Add cancellation token support for the [Gif]SnapshotAsync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.