Added overloads to the FFProbe.GetFrames and FFProbe.GetFramesAsync methods to allow passing in Stream objects#608
Open
ememadegbola wants to merge 4 commits intorosenbjerg:mainfrom
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #608 +/- ##
==========================================
+ Coverage 71.72% 71.89% +0.16%
==========================================
Files 123 123
Lines 3544 3526 -18
Branches 311 304 -7
==========================================
- Hits 2542 2535 -7
+ Misses 888 876 -12
- Partials 114 115 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ememadegbola
force-pushed
the
GetFramesStream
branch
from
b11efdb to
f8cc067
Compare
- Reordered public methods so Analyse, GetFrames and GetPackets (and their overloads) are grouped together for readability - Updated synchronous overloads to call the corresponding async implementations and wait with ConfigureAwait(false).GetAwaiter().GetResult() to avoid duplicated logic
ememadegbola
force-pushed
the
GetFramesStream
branch
from
f8cc067 to
68d359b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added overloads to the
FFProbe.GetFramesandFFProbe.GetFramesAsyncmethods to allow passing in Stream objectsFFProbeAnalyse and GetFrames methods to all share the same backing logic and reduce code duplicationTesting Enhancements:
FrameAnalysis_FromStream_SyncandFrameAnalysis_FromStream_Asyncto verify frame extraction from aStreamsource, both synchronously and asynchronously. [1] [2]