Open
Conversation
nbesimi
commented
May 8, 2023
| private static final String TRANSLATION_TABLE_NAME = "TRANSLATION"; | ||
| private static final String TRANSLATION_ATTRIBUTE_TABLE_NAME = "TRANSLATION_ATTRIBUTE"; | ||
|
|
||
| private static final String DATABASE_TEMPLATE_TABLE_NAME = "DATABASE_TEMPLATE"; |
Contributor
Author
nbesimi
commented
May 8, 2023
| return new BufferedReader(new InputStreamReader(resourceAsStream)); | ||
| } | ||
|
|
||
| private BufferedReader readDatabaseTemplateFile() throws FileNotFoundException { |
Contributor
Author
There was a problem hiding this comment.
@ailegion for this I did not add an ENV variable. Should we allow users to override the database template file?
nbesimi
commented
May 8, 2023
| @@ -0,0 +1,27 @@ | |||
| package com.adaptivescale.rosetta.ddl; | |||
|
|
|||
| public enum DatabaseTemplateEnum { | |||
Contributor
Author
nbesimi
commented
May 8, 2023
| createParams.put("tableName", table.getName()); | ||
| createParams.put("tableCode", definitionAsString); | ||
| stringBuilder.append(TemplateEngine.process(TABLE_CREATE_TEMPLATE, createParams)); | ||
| Optional.ofNullable(databaseTemplates.get(TABLE_CREATE.getName())) |
Contributor
Author
nbesimi
commented
May 8, 2023
Contributor
Author
There was a problem hiding this comment.
We need this file here because of the unit tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.