Skip to content

Conversation

@JMoore5353
Copy link
Contributor

This PR:

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses a state message field access bug introduced in PR #47 and updates controller/vehicle parameters based on hardware testing results.

Key Changes:

  • Fixed state message field references from array indexing to named struct members
  • Updated PID controller gains for improved performance based on hardware tests
  • Adjusted vehicle physical parameters to match actual hardware measurements

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
roscopter/src/controller/controller_cascading_pid.cpp Fixed state message field access to use named members instead of array indices
roscopter/params/multirotor.yaml Updated PID gains and velocity limits based on hardware test results
roscopter/config/multirotor_frame_config.yaml Updated physical parameters (mass, air density, voltage, prop coefficient) to match actual hardware

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@JMoore5353 JMoore5353 merged commit bb6e165 into main Dec 15, 2025
0 of 2 checks passed
@JMoore5353 JMoore5353 deleted the jacob/fix-state-message-error branch December 15, 2025 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants