-
Notifications
You must be signed in to change notification settings - Fork 20
update to 0.6.1 #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
update to 0.6.1 #14
Conversation
|
I'm not 100% sure but I'm pretty sure you need to update the checksum as well so it matches 0.6.0. I believe Were you able to run test kitchen successfully after upping the version? Mine failed, throwing a git error, which I thought was related to |
|
Thanks for the PR @dayne I would indeed expect the shasum to change too. Also, this test: https://github.com/rosstimson/chef-ruby_install/blob/master/test/integration/installation/serverspec/installation_spec.rb#L15 |
|
Has the reason that this PR not been merged only that the checksum needs to be updated? The current checksum for ruby-install 0.6.0 is |
cleaning out comments.
these converge and verify successfully.
|
Since submitting this pull request I've leveled up on understanding the test kitchen and important that part of a pull request is. I've come back to this pull request and updated it to 0.6.1, correct checksum, and updated test kitchen environment to ensure this cookbook is still relevant on modern systems and updated rubies. The kitchen suite Thanks |
note: jruby and rbx do not really work on modern platforms. ruby-install would need to be updated it appears.
No description provided.