Skip to content

Conversation

@WadeTheFade
Copy link

resolves #3 and adds #5 and #6

I got it working, but was unable to resolve the testing.

Merging to develop in case someone can address before I get a chance.

@WadeTheFade
Copy link
Author

I've found an issue with bindEnglishTo when selecting different scheduleTypes.

There are a few different approaches to fixing.. my first impression is to only call toEnglishString() is validate passes.

I'll try to address this and the failing checks in the next commit.

@kingofzeal
Copy link
Contributor

This looks good.

Would it be possible to get some unit tests wired up to test the new hourly options as well? I would want to make sure that especially the cron output is what we would expect for a given combinations of options (and vice versa, a provided cron string updates the DOM with the correct options).

@WadeTheFade
Copy link
Author

WadeTheFade commented Aug 13, 2018

Yeah there is a bug in the monthly/yearly selection when bindEnglishTo() when loading a default schedule that isn't monthly/yearly:
Not implemented: Monthly.undefined.toEnglishString.

I'll try to address this and the unit tests around hourly soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants