Skip to content

Conversation

@ananthb
Copy link
Member

@ananthb ananthb commented Jan 22, 2026

We were using the wrong certificate identifier so requests were failing.

@ananthb ananthb merged commit 322266f into master Jan 22, 2026
1 check passed
@ananthb ananthb deleted the fix-api branch January 22, 2026 10:17
@github-actions
Copy link

Code Coverage Report

Total Coverage: total: (statements) 31.7%

Coverage by function

==========================================
  Certificator Development Environment
==========================================

Go version (from go.mod): 1.25.5
Go version (active):      go1.25.5
HAProxy version:          HAProxy version 3.3.0-7832fb2 2025/11/26 - https://haproxy.org/
Data Plane API:           2026/01/22 10:25:01 maxprocs: Leaving GOMAXPROCS=4: CPU quota undefined

Available commands:
  build            - Build certificator and certificatee
  run-tests        - Run unit tests
  test-coverage    - Run tests with coverage report
  test-watch       - Watch for changes and run tests
  tidy             - Tidy go.mod dependencies
  check            - Run all checks (fmt, vet, lint, test)
  clean            - Clean build artifacts

github.com/vinted/certificator/cmd/certificatee/helpers.go:9:		createHAProxyClients		0.0%
github.com/vinted/certificator/cmd/certificatee/main.go:23:		main				0.0%
github.com/vinted/certificator/cmd/certificatee/main.go:74:		maybeUpdateCertificates		0.0%
github.com/vinted/certificator/cmd/certificatee/main.go:90:		processHAProxyEndpoint		0.0%
github.com/vinted/certificator/cmd/certificatee/main.go:161:		shouldUpdateCertificate		0.0%
github.com/vinted/certificator/cmd/certificatee/main.go:187:		serialsDiffer			100.0%
github.com/vinted/certificator/cmd/certificatee/main.go:199:		formatSerial			100.0%
github.com/vinted/certificator/cmd/certificatee/main.go:203:		updateCertificate		0.0%
github.com/vinted/certificator/cmd/certificatee/main.go:225:		buildPEMBundle			100.0%
github.com/vinted/certificator/cmd/certificatee/main.go:251:		endsWith			100.0%
github.com/vinted/certificator/cmd/certificator/main.go:18:		main				0.0%
github.com/vinted/certificator/pkg/acme/acme.go:27:			GetEmail			0.0%
github.com/vinted/certificator/pkg/acme/acme.go:32:			GetRegistration			0.0%
github.com/vinted/certificator/pkg/acme/acme.go:37:			GetPrivateKey			0.0%
github.com/vinted/certificator/pkg/acme/acme.go:42:			NewClient			0.0%
github.com/vinted/certificator/pkg/acme/acme.go:61:			setupClient			0.0%
github.com/vinted/certificator/pkg/acme/acme.go:80:			setupAccount			0.0%
github.com/vinted/certificator/pkg/acme/acme.go:118:			newAccount			0.0%
github.com/vinted/certificator/pkg/acme/acme.go:130:			getAccountKey			0.0%
github.com/vinted/certificator/pkg/acme/acme.go:159:			registerAccount			0.0%
github.com/vinted/certificator/pkg/acme/acme.go:177:			recoverAccount			0.0%
github.com/vinted/certificator/pkg/acme/acme.go:211:			saveAccount			0.0%
github.com/vinted/certificator/pkg/acme/acme.go:221:			saveKey				0.0%
github.com/vinted/certificator/pkg/certificate/certificate.go:18:	ObtainCertificate		0.0%
github.com/vinted/certificator/pkg/certificate/certificate.go:50:	GetCertificate			0.0%
github.com/vinted/certificator/pkg/certificate/certificate.go:68:	NeedsReissuing			0.0%
github.com/vinted/certificator/pkg/certificate/certificate.go:96:	arraysEqual			0.0%
github.com/vinted/certificator/pkg/certificate/certificate.go:110:	arrayContains			0.0%
github.com/vinted/certificator/pkg/certificate/certificate.go:119:	VaultCertLocation		0.0%
github.com/vinted/certificator/pkg/certificate/certificate.go:123:	storeCertificateInVault		0.0%
github.com/vinted/certificator/pkg/certmetrics/metrics.go:61:		StartMetricsServer		0.0%
github.com/vinted/certificator/pkg/certmetrics/metrics.go:81:		PushMetrics			0.0%
github.com/vinted/certificator/pkg/config/config.go:72:			LoadConfig			0.0%
github.com/vinted/certificator/pkg/haproxy/client.go:60:		NewClient			100.0%
github.com/vinted/certificator/pkg/haproxy/client.go:95:		NewClients			92.3%
github.com/vinted/certificator/pkg/haproxy/client.go:120:		Endpoint			100.0%
github.com/vinted/certificator/pkg/haproxy/client.go:125:		doRequest			88.9%
github.com/vinted/certificator/pkg/haproxy/client.go:159:		ListCertificates		100.0%
github.com/vinted/certificator/pkg/haproxy/client.go:173:		ListCertificateRefs		85.7%
github.com/vinted/certificator/pkg/haproxy/client.go:211:		GetCertificateInfo		100.0%
github.com/vinted/certificator/pkg/haproxy/client.go:216:		GetCertificateInfoByPath	84.2%
github.com/vinted/certificator/pkg/haproxy/client.go:251:		GetCertificateInfoByRef		0.0%
github.com/vinted/certificator/pkg/haproxy/client.go:262:		parsePEMCertificate		87.5%
github.com/vinted/certificator/pkg/haproxy/client.go:287:		parseDataPlaneAPITime		100.0%
github.com/vinted/certificator/pkg/haproxy/client.go:308:		UpdateCertificate		80.0%
github.com/vinted/certificator/pkg/haproxy/client.go:344:		CreateCertificate		78.9%
github.com/vinted/certificator/pkg/haproxy/client.go:379:		DeleteCertificate		100.0%
github.com/vinted/certificator/pkg/haproxy/client.go:398:		ExtractDomainFromPath		100.0%
github.com/vinted/certificator/pkg/haproxy/client.go:416:		IsExpiring			100.0%
github.com/vinted/certificator/pkg/haproxy/client.go:427:		NormalizeSerial			100.0%
github.com/vinted/certificator/pkg/haproxy/client.go:437:		Error				100.0%
github.com/vinted/certificator/pkg/haproxy/client.go:441:		Info				0.0%
github.com/vinted/certificator/pkg/haproxy/client.go:445:		Debug				100.0%
github.com/vinted/certificator/pkg/haproxy/client.go:449:		Warn				0.0%
github.com/vinted/certificator/pkg/haproxy/client.go:454:		toLogrusFields			85.7%
github.com/vinted/certificator/pkg/vault/vault.go:18:			NewVaultClient			0.0%
github.com/vinted/certificator/pkg/vault/vault.go:27:			KVWrite				0.0%
github.com/vinted/certificator/pkg/vault/vault.go:41:			KVRead				0.0%
github.com/vinted/certificator/pkg/vault/vault.go:62:			vaultFullPath			0.0%
total:									(statements)			31.7%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant