Skip to content

Conversation

@leafaar
Copy link
Contributor

@leafaar leafaar commented Nov 17, 2025

No description provided.

@leafaar leafaar requested a review from lvboudre November 17, 2025 19:31
@leafaar
Copy link
Contributor Author

leafaar commented Nov 17, 2025

@grooviegermanikus I can't add you as a reviewer, but would have to have your review here 😁

@grooviegermanikus
Copy link
Contributor

can check tomorrow morning. xheers

Copy link
Contributor

@grooviegermanikus grooviegermanikus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not 100% sure but that max_core_id might be wrong

Copy link
Contributor

@grooviegermanikus grooviegermanikus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

});
}

for _ in 0..config.tokio.worker_threads.unwrap_or(1) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this might be an issue if we don't specify worker threads... I need to review.

@leafaar leafaar marked this pull request as draft January 23, 2026 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants