ASVS/MASVS fields for Findings #13
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* CVSS: temporal and environmental scores.
* Update hidden field values for cvss
* Update hidden fields values for cvss
Icons for environmental and temporal metrics.
Owner
|
The work is fine, but I can not add REQUIRED fields (like SCA and SAST) to the main branch if they are not completely work-flow independent. Also, in order to avoid the unnecessary grow of model and forms definition, I rather prefer some kind of dynamic meta-field in assessment and findings to let you an everyone configure custom fields as they needed them. The use of the full CVSS calculator is OK for me, at first it looks a little bit massive but, I think is a good idea. |
Author
|
You're right, I'll make them nullable. About the model and forms definition growth, would you care to explain what you mean by "dynamic meta-field"? is there any example already in code? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @rsrdesarrollo,
I thought it would be interesting to be able to relate each finding to the security requirement that, if implemented following the OWASP standards for web applications (ASVS) and mobile applications (MASVS), would have prevented it.
Since you're already using the testing guides, I considered this to be some valuable additional information.
Both fields have been added to the finding and finding template tables.