fix: Allow browser authentication to Snowflake from the Deploy pane#1290
Open
fix: Allow browser authentication to Snowflake from the Deploy pane#1290
Conversation
The `snowflakeauth` package only permits external browser authentication from interactive contexts, which makes sense in most cases. However, push-button deployments from the RStudio IDE actually run in a separate Deploy pane, not from the interactive console -- which isn't considered "interactive" by default. So this commit tells `rlang` to temporarily treat this as an interactive context, which allows the browser flow to work. Fixes #1289. Signed-off-by: Aaron Jacobs <aaron.jacobs@posit.co>
atheriel
force-pushed
the
aj-interactive-in-deploy-pane
branch
from
b569eb9 to
5cede55
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
snowflakeauthpackage only permits external browser authentication from interactive contexts, which makes sense in most cases.However, push-button deployments from the RStudio IDE actually run in a separate Deploy pane, not from the interactive console -- which isn't considered "interactive" by default.
So this commit tells
rlangto temporarily treat this as an interactive context, which allows the browser flow to work.This actually requires a change to the
snowflakeauthpackage as well: posit-dev/snowflakeauth@dbd4830. We'll have to get another release of that package out to enable this fix to work properly.Fixes #1289.