Skips Docker service start on WSL environments #313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents attempts to enable or start the Docker systemd service when running inside WSL, avoiding unnecessary errors and clarifying that Docker Desktop should be managed via the Windows host. Improves installation script compatibility with WSL systems.
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the installation script to properly handle WSL (Windows Subsystem for Linux) environments by detecting when the script is running inside WSL and skipping Docker systemd service operations, which are not applicable in WSL when using Docker Desktop from the Windows host.
- Adds a new
is_wsl()function to detect WSL environments by checking for "microsoft" in/proc/versionor/proc/sys/kernel/osrelease - Modifies
install_docker_ubuntu()to skip Docker service start/enable operations in WSL environments - Provides clear user guidance to ensure Docker Desktop is running on the Windows host
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents attempts to enable or start the Docker systemd service when running inside WSL, avoiding unnecessary errors and clarifying that Docker Desktop should be managed via the Windows host. Improves installation script compatibility with WSL systems.