Ensure restart policy for services #317
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a critical issue where Docker containers fail to automatically restart after server reboot by adding restart policies to all service definitions across three Docker Compose template files.
- Added
restart: unless-stoppedpolicy to site-level services, workers, and admin tools - Ensures automatic recovery from server reboots without manual intervention
- Maintains consistency with existing global services that already use
restart: always
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| frappe_manager/templates/docker-compose.tmpl | Added restart policy to 6 site services (frappe, nginx, socketio, schedule, redis-cache, redis-queue) |
| frappe_manager/templates/docker-compose.workers.tmpl | Added restart policy to worker service template |
| frappe_manager/templates/docker-compose.admin-tools.tmpl | Added restart policy to admin tools (mailpit, adminer) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
This PR also need to cover the migration of previous site and we should also provide a flag at the time of creation of site like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #316
This PR fixes a critical issue where Docker containers don't automatically restart after server reboot, causing complete service outages until manual intervention.
Changes Made
Added
restart: unless-stoppedpolicy to all services across three Docker Compose template files:1. docker-compose.tmpl (Site Services)
2. docker-compose.workers.tmpl (Worker Services)
3. docker-compose.admin-tools.tmpl (Admin Tools)
4. docker-compose.services.tmpl (Global Services)
restart: always(no change needed)restart: always(no change needed)