Open
Conversation
|
@shivamsn97 hi bro, do you know any projects done by this? |
b1ink0
requested changes
Feb 16, 2026
Comment on lines
170
to
171
| <Listbox value={value} onChange={onChange} disabled={isDisabled}> | ||
| <Popover |
Collaborator
There was a problem hiding this comment.
Now that we have base-ui in the repo, please refactor to use base-ui. This will also ensure that we don’t have to use the Popover component.
…nsure codebase consistency
…nsure codebase consistency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a new
Selectcomponent to the Frappe UI React library, providing a fully accessible dropdown selection input with multiple variants and states.Features
subtle,outline,ghost— matching existing component patternssuccess,warning,errorfor form feedbackImplementation Details
@headlessui/reactListbox with non-deprecated components (ListboxOptioninstead ofListbox.Option)ink-*,surface-*,outline-*) for theming consistencyPopovercomponent for dropdown positioningtypes.tsfileFiles Added/Modified
select.tsx— Main component implementationtypes.ts— TypeScript type definitionsselect.stories.tsx— Storybook stories with autodocsindex.ts— Exportstests/select.tsx— Unit testsStorybook
Testing
Checklist
pnpm lint:js)pnpm lint:types)select.component.mp4