[CommandPalette] Add Storybook stories#211
[CommandPalette] Add Storybook stories#211Rohitgautam02 wants to merge 1 commit intortCamp:developfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds Storybook documentation coverage for the CommandPalette component by introducing a dedicated stories file demonstrating key variants and behaviors.
Changes:
- Added a new
commandPalette.stories.tsxwith 5 story variants (default, multiple groups, disabled items, hidden group title, keyboard shortcut). - Implemented per-story state for
showandsearchQuery, plus basic client-side filtering of groups/items.
packages/frappe-ui-react/src/components/commandPalette/commandPalette.stories.tsx
Outdated
Show resolved
Hide resolved
packages/frappe-ui-react/src/components/commandPalette/commandPalette.stories.tsx
Outdated
Show resolved
Hide resolved
packages/frappe-ui-react/src/components/commandPalette/commandPalette.stories.tsx
Outdated
Show resolved
Hide resolved
packages/frappe-ui-react/src/components/commandPalette/commandPalette.stories.tsx
Outdated
Show resolved
Hide resolved
packages/frappe-ui-react/src/components/commandPalette/commandPalette.stories.tsx
Outdated
Show resolved
Hide resolved
packages/frappe-ui-react/src/components/commandPalette/commandPalette.stories.tsx
Outdated
Show resolved
Hide resolved
packages/frappe-ui-react/src/components/commandPalette/commandPalette.stories.tsx
Outdated
Show resolved
Hide resolved
packages/frappe-ui-react/src/components/commandPalette/commandPalette.stories.tsx
Outdated
Show resolved
Hide resolved
packages/frappe-ui-react/src/components/commandPalette/commandPalette.stories.tsx
Outdated
Show resolved
Hide resolved
packages/frappe-ui-react/src/components/commandPalette/commandPalette.stories.tsx
Outdated
Show resolved
Hide resolved
|
@Rohitgautam02 important thing all commits must be signed with GPG so they show the "Verified" badge on GitHub. PRs with unsigned commits will not be accepted. Follow GitHub's official guide: https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits |
29e6dee to
c6d2d89
Compare
|
Addressed all review feedback from Copilot:
Commit is now GPG-signed and verified. |
|
|
@Rohitgautam02, could you please create a branch from the latest |
|
Also, please resolve the Copilot review yourself if you have addressed it. |
c6d2d89 to
ee0eaac
Compare
|
@b1ink0 Rebased the branch onto the latest Also resolved all Copilot review threads (all feedback was already addressed in the previous force-push). |
|
@b1ink0 @mohdsayed sir please check this out and review me something so that I can proceed ahead and learn and contribute more also I am actively looking for opportunities and work so if you can guide and assist me that will be really helpful |
Description
Added Storybook stories for the CommandPalette component which was missing documentation.
Relevant Technical Choices
Added 5 stories covering all component features:
hideTitle: trueto hide group headersFollowed existing story patterns from other components (Dialog, Combobox, Badge).
Testing Instructions
pnpm storybookAdditional Information
This is a documentation improvement. All checks pass:
pnpm lint:types- cleanpnpm lint:js- no errors from new filepnpm build-storybook- builds successfully