fix uninitialized chd_file in chd_read_header #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
at the cleanup label, it checks if chd.file != NULL, but if filename or header was NULL then chd will be uninitialized i saw this as a gcc warning while building libchdr. IDK if it is causing any problems but it is definitely something that should be fixed.
Contributor
|
There are more warnings than this when building with a new compiler, would be nice with some cleaner output. |
Owner
|
@hrydgard Agreed, we need to clean up and accomodate newer Clang / GCC while keeping compatibility with older GCC / exotic old toolchains |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
at the cleanup label, it checks if chd.file != NULL, but if filename
or header was NULL then chd will be uninitialized
i saw this as a gcc warning while building libchdr. IDK if it is
causing any problems but it is definitely something that should be fixed.