#25 feat: added password strength validator #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nikhil-IITG
changed the title
Nikhil-IITG
changed the title
Nikhil-IITG
changed the title
rubemfsv
requested changes
Nov 7, 2023
| const mediumRegex = new RegExp("^(?=.{6,}).*$"); | ||
|
|
||
| //logic | ||
| if(value.length<4){ |
Owner
There was a problem hiding this comment.
try to improve this logic due to the object calisthenics
| const mediumRegex = new RegExp("^(?=.{6,}).*$"); | ||
|
|
||
| //logic | ||
| if(value.length<4){ |
Owner
There was a problem hiding this comment.
try to improve this logic due to the object calisthenics, and add strings to an enum
Nikhil-IITG
commented
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Password Strength Validator with some customisations, hope this works and you like it. I've attached some pictures of how it looks.