Skip to content

Remove ENABLE_NUMERIC_STRING flag #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tompng merged 1 commit into from
Dec 25, 2025
Merged

Remove ENABLE_NUMERIC_STRING flag #479

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions ext/bigdecimal/bigdecimal.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,6 @@

#define BIGDECIMAL_VERSION "4.0.1"

/* #define ENABLE_NUMERIC_STRING */

#define SIGNED_VALUE_MAX INTPTR_MAX
#define SIGNED_VALUE_MIN INTPTR_MIN
#define MUL_OVERFLOW_SIGNED_VALUE_P(a, b) MUL_OVERFLOW_SIGNED_INTEGER_P(a, b, SIGNED_VALUE_MIN, SIGNED_VALUE_MAX)
Expand Down Expand Up @@ -336,14 +334,6 @@ GetBDValueWithPrecInternal(VALUE v, size_t prec, int must)
break;
}

#ifdef ENABLE_NUMERIC_STRING
case T_STRING: {
const char *c_str = StringValueCStr(v);
v = rb_cstr_convert_to_BigDecimal(c_str, must);
break;
}
#endif /* ENABLE_NUMERIC_STRING */

default:
goto SomeOneMayDoIt;
}
Expand Down