Bump ruby/setup-ruby from 1.222.0 to 1.227.0#619
Conversation
Bumps [ruby/setup-ruby](https://github.com/ruby/setup-ruby) from 1.222.0 to 1.227.0. - [Release notes](https://github.com/ruby/setup-ruby/releases) - [Changelog](https://github.com/ruby/setup-ruby/blob/master/release.rb) - [Commits](ruby/setup-ruby@277ba2a...1a61595) --- updated-dependencies: - dependency-name: ruby/setup-ruby dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
|
@headius Can you look this failure? https://github.com/ruby/rake/actions/runs/14029508755/job/39274018938?pr=619#step:5:11 |
|
@hsbt I will investigate! |
|
The root cause appears to be a rake test that raises with a US-ASCII string that actually has UTF-8 MBC in it, like this: That error's message gets reported via a StringIO in the "trace" logic in Rake, and StringIO eventually calls the equivalent of |
|
Working on it now: jruby/jruby#8710 |
We expect exceptions from catString, so just re-raise directly. This caused the ugly internal RuntimeException trace in ruby/rake#619. This does not fix that issue, but it properly lets the original Ruby exception propagate.
We expect exceptions from catString, so just re-raise directly. This caused the ugly internal RuntimeException trace in ruby/rake#619. This does not fix that issue, but it properly lets the original Ruby exception propagate.
|
@hsbt The "fix" feels kinda hacky, because only minor changes are required to cause CRuby to fail the same way. The fix was to make JRuby's backtrace elements have a code range of 7BIT when they can be 7BIT, rather than defaulting to VALID: jruby/jruby#8711 The explanation of why this fixes the problem, and why the test is very fragile: jruby/jruby#8710 (comment) Basically, it's easy to make CRuby also fail this just by checking I'm not sure this test is actually useful, since it only passes under a very specific set of circumstances. Nevertheless, I have fixed JRuby and found a few other small fixes for StringIO (ruby/stringio#124). |
|
@hsbt I have pushed a new snapshot of JRuby 10 and a new release of jruby-head for Ruby installers. These tests should pass now. |
We expect exceptions from catString, so just re-raise directly. This caused the ugly internal RuntimeException trace in ruby/rake#619. This does not fix that issue, but it properly lets the original Ruby exception propagate.
|
@headius Thanks. I confirmed with |
Bumps ruby/setup-ruby from 1.222.0 to 1.227.0.
Release notes
Sourced from ruby/setup-ruby's releases.
Commits
1a61595Add truffleruby-24.2.0,truffleruby+graalvm-24.2.0922ebc4Use $JAVA_HOME/bin/java for the check6c79f72Test successful JRuby start without using launchere17c5eaHandle exec errorf0a4d6bSwitch JAVA_HOME to 21 for JRuby (#721)bbda858Fix .tool-versions and mise.toml tests30755d8Cleanup matching for .tool-versions and mise and add tests for .ruby-version ...28233a0bugfix: Fix bug that version cannot be parsed in .tool-versionsDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)