Merged
Conversation
08a818b to
7b86582
Compare
Member
|
Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
A warning is currently emitted in CI when running with ruby-head (Ruby 3.5-dev).
This warning occurs because
CGI::Utilwill be removed in Ruby 3.5.cgi/escaperuby#13275https://github.com/ruby/rss/actions/runs/16902042489/job/47883073913#step:6:8
Details
This Pull Request fixes the warning by replacing the use of
cgi/utilwithcgi/escape.The
cgi/escapeis available since Ruby 2.3.In addition, for Ruby 3.4 and earlier,cgi/utilis still required to use methods such asCGI.escape*andCGI.unescape*(especiallyCGI.escapeHTMLin the rss gem).(
cgi/utilwas only required when usingCGI.unescapemethod on Ruby 3.4 and earlier.)Additional Information
Similar fixes have been made in other libraries, such as the rdoc gem.
cgi/escapeinstead ofcgi/utilrdoc#1366