Add --no-sudo option to skip all operations that require sudo #474
+17
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running benchmarks on machines without sudo access, the CPU configuration (turbo boost, min_perf_pct, frequency governor) cannot be set or verified. The --no-sudo flag skips the entire CPUConfig setup, which includes both the sudo-dependent writes and the checks that exit when the expected configuration isn't detected.
Member
|
Nice! Personally I use this when I just run a benchmark to check if it runs fine or getting stats or so, and I don't want to make my machine stay in "benchmark mode / don't save power mode" after. (one could run the benchmark directly without |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
--no-sudooption that skips all operations that require sudo.When running benchmarks for testing behaviors or collecting stats, it's just annoying that it prompts me to input sudo password after some period of time. So I want to use this
--no-sudoin that case.--turbo#307 currently serves a similar purpose, but it doesn't disable themin_perf_pctfeature which also requires sudo and it annoys me. I'm not deleting--turboin this PR; I want to remove--turbolater to leave some time for people to migrate to it.While #354 is in progress to land
--no-benchmark-mode, I want to have this feature before finishing the whole refactoring, and I want the name to be shorter because I often need to type it locally.