Fallback git/path sources to default source #9301
Merged
+75
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
We've added a feature that uses git source to resolve bundler dependencies, including activerecord, on which Rails depends, in git monorepo such as
rails/rails.However, since
railsdependencies, such asrack, are not in the rails monorepo, it is appropriate to use the default source, rubygems.org, for such gems.Fixes #9258
What is your fix for the problem, implemented in this PR?
The if statement on line 1080 now uses
parent_dep.sourceonly if the source indicated byparent_dephas target gemspec.Make sure the following tasks are checked